Hi there! Thanks for using the script!
I'll look into those reports probably next weekend.
1 Like
Actually, I just took a quick look:
- https://vgmdb.net/album/17990 fails because it does not contain a tracklist. The tracklist is read right after VGMDB_ALL_CREDITS and errors out because of that. No tracklist means no tagging, because I would need at least the number of tracks in an album to use dummy entries or recycle already used tags.
- https://vgmdb.net/album/16205 fails because VGMDB seems to have rewritten part of their page code... This should affect all entries with more than one disc... ouch. This will take a while to fix.
- https://vgmdb.net/album/20429 fails because I assumed that there would be at least one product associated with an entry. This is an easy fix.
1 Like
I appreciate the quick peak into the issues. as for the first one (17990) that makes sense. most of the ones I have that errored on this tag were also missing a track list. I did find one that does have a tracklist, but still errored /album/77045 (sorry my last post got flagged for links I guess?) Not sure if that'll help find a way around it, or just complicate things more!
As for the second one, it appears they haven't changed it over for all as about 90% of my multidisc tags still worked. That probably means it's going to be even more complex (sorry!)
Great to hear about the 3rd one being an easy fix.
I am sure I had/will have a few more special case ones that I can throw your way if you're up for the challenge. You're a legend!
Could you please check if the attached version fixes the second and third issue you raised?
I checked a few albums but I currently do not have the time to test a reliable number of albums myself, sorry.
VGMdb_by_URL.src (106.5 KB)
At the moment, I don't have too many to test. But all the ones I did test are working fine. For those without a tracklist, is there no way to just have it only pull album tags? I'm not sure if that's possible, or something you'd even want to tackle. Again, thank you for addressing these two issues. I now have some work to do for all the albums I've tagged over the years.
Version 2.2.0-20240602
- Fixed an error when there are no associated products for an album
- Fixed an error parsing multi-disc albums
- Added support for the "Music Credit" (VGMDB_MAIN_CREDITS_MUSIC)
Version 2.3.0-20240611
- Added VGMDB_TOTALTRACKS and VGMDB_TOTALDISCS
- Added more fields to the default mapping
VGMdb_by_URL.src (113.4 KB)
1 Like
I found a few albums with this "sub-title" track listing. I imagine this might be a bit difficult to tackle; any ideas?
/album/229
/album/81915
/album/81916
/album/3847
/album/3838
/album/3860
just my personal preference, but I'd love to "ignore" them, as none of my tracks are split that way
I appreciate the follow-up releases. My collection and I thank you, immensely
I've never encountered those... As you guessed this is pretty complicated and outside of the scope of this script as I would need to rewrite the whole handling of the disc section.
Hi GiFuJo, thanks for your script, it is absolutely fantastic. However I have encountered a bit trouble on getting artist's japanese name. Seems like the by default the script only get the artists' enligsh name rather than their japanese kanji/romanji name. Is there any fix for that? Thank you. Example is https://vgmdb.net/album/81525
I've looked into it. Please try out the new version. It contains _ORIGINAL and _TRANSLATED versions for all credits. You can remap them starting from line 3518 or using the Tag to Tag converter feature.
Please test it out and report back any errors as I don't have time to do broad tests myself!
Version 2.4.0-20240815
- Added original and translated versions of all credits; translated versions are used by default
VGMdb_by_URL.src (122.9 KB)
Small update:
Version 2.4.1-20240815
- Fixed credits containing the "Uncredited" information
VGMdb_by_URL.src (124.8 KB)
And another small update:
Version 2.4.2-20240815
- Fixed credit indicator in ALL_CREDITS sometimes being translated and sometimes being not; this seems to be random behavior by VGMdb...
VGMdb_by_URL.src (125.2 KB)
1 Like
Hi GiFuJo, thank for your update.
With the lastest 125.2KB script it is now possible to find the Kanji album artist info. Though there is a small imperfection exist, the VGMDB_MAIN_CREDITS_MUSIC_ORIGINAL tag seems to lock on the credit of track#1 of Disc1. Example is https://vgmdb.net/album/81525, where Kenji Kawai is the main composer and album artist for 51 out of 53 tracks, but the artist tag for songs of entire album seems lock on to the vocals of the track #1. Swapping the position of VGMDB_MAIN_CREDITS_MUSIC_ORIGINAL and VGMDB_MAIN_CREDITS_VOCAL_ORIGINAL does not make any differnce. Is the MUSIC_ORIGINAL tag an standalone information provided directly by VGMDB or is it just a varaiable created by the script for mapping information only?
Thank you
1 Like
Thats likely because vgmdb doesn't provide credits for each track and instead it uses the notes box for all that.
The script does its best to tag with the given information as the notes box is impossible to parse as anything can be typed in there.
Exactly, VGMdb only provides track specific data for Tracknumber, Title and Length. All other data is for the whole album. Because of that you see lots of albums with track specific information plastered all over the comment/description.
I updated the script to account for some edgecases I found:
Version 2.4.3-20240816
- Fixed a few more edgecases with credits
VGMdb_by_URL.src (126.0 KB)
1 Like
Thats great to know, thank you again! So do with Onurtag's nice explaination, highly appreciate the fast responses from both of you!
Thanks! I've been running my own modified version of the other script that I hacked together, so I'll try this one out and see how it goes. Being limited to only the first 8 CDs is a big negative though for things such as boxsets, can that be extended? The other VGMDB script doesn't seem to have a limit on it.
One of the fields I added myself is the Event, for doujin/special event releases.
# Event
outputto "Event"
findinline "/db/icons/event_first_release.png' />" 1 1
sayuntil "</span>"
I also added some regex replace to remove URLs from the notes.
regexpreplace "</a>" ""
regexpreplace "<a href=\"/album/[0-9 ]+\">" ""
I didn't even realize the events... I'll look into including those in the next version.
I thought about removing HTML tags from the notes, but some music players actually seem to render those, so I'm not sure about changing the contents of notes.
Version 2.4.4-20240901
- Remove HTML tags from Notes/Description (VGMDB_NOTES)
- Added "Release Event" (VGMDB_RELEASE_EVENT)
VGMdb_by_URL.src (127.2 KB)
As always, please report back any URLs not working.
Small hotfix:
Version 2.4.5-20240901
- Fixed an error when Notes/Description is empty
VGMdb_by_URL.src (127.3 KB)
2 Likes