Now that we have a custom toolbar, I wanted to move the Filter bar to it. I can, but after quitting and re-running Mp3tag, it has been moved out of the custom toolbar to a row of its own. Ideally it'd work for the custom toolbar just like it does for the main one.
Yes I am. And you're correct about it working on the custom toolbar when placed on its right. Maybe that's the case for the main toolbar too.
The goal was getting the icons on the right and the Filter bar effectively works like a spacer pushing them there. Reason being is that my most used item is typically first but that makes it also the farthest away. Pushing the icons to the right means the first is more economically accessible (closer to the middle). I could just reverse the icons and keep the on the left but it's a little awkward imo.
Allowing the Filter bar on the left side and / or potentially adding a dedicated spacer toolbar item would be nice.
What I've done is add a bunch of inconsequential "About Mp3tag..." buttons which do not have an icon to the toolbar so they act as spacers which kind of solves the problem I was having. Shame about the Filter bar.
The solution looks fine, however my first attempt was adding an empty action to the toolbar and assigning it the no-icon icon but for some reason it always renders as a black square rather than "invisible" (bug). Default items like "About Mp3tag..." with the no-icon icon set don't have the same issue.
A couple other titbits that I noticed that may be an issue: Consecutive separators don't render; if a separator is the first or last item on the toolbar, it also doesn't render.
I intentionally added the removal of multiple consecutive separators to prevent cases where disabling toolbar items, especially those between two separators, leaves behind duplicate separators.
It seems I can never anticipate all possible use cases for a feature
That makes sense. I was just adding a couple separators to the toolbar's start to align the buttons better with those on the main toolbar above. But it's not a big issue: I just added them after my pseudo-spacers and before my real buttons begin. Anyway, thanks for the recent improvements to Mp3tag
I've tried again and got it working this time around. Can you try Mp3tag v3.35-beta.1? The Filter should now also keep it's position when arranged left of a toolbar.
The new version also has a dedicated spacer toolbar item.
Tested. The Filter bar stays positioned on the Custom toolbar's left across sessions. Nice addition of a spacer, however, it has the same issue as separators. A flexible spacer like in Firefox would be cool too.
Previously I agreed that it makes sense that consecutive separators aren't displayed, however I think if you're hiding a toolbar item, how much more effort is it really to also hide the duplicate separator whilst you're at it? I have no need for it now with the spacer (thank you), but I can't imagine hiding and showing toolbar items manually would be common. Even less common if you ever implement some kind of toolbar sets feature to swap out the entire set of buttons for another.
Following this logic, presumably spacers would behave in the same way, but they do not (a removed item surrounding by 2 spacers does not result in 1 spacer -- not that I personally want this behaviour, but presumably some might for the same reasons as for the consecutive separators).
However, spacers do behave in the same way as separators when it comes to being the first or last item in the toolbar, which isn't ideal when you have the Filter bar in front of the first item for example. I guess the toolbar technically starts after the Filter bar, but it would be nice to be able to use a spacer or multiple between the Filter and the toolbar.
My complaints would be solved by making separators and spacers dumb and instead relying on the user to disable the adjacent spacer or separator when disabling the final icon within a contiguous section of items (a minor inconvenience in my opinion, and even less so with a hypothetical toolbar sets feature).