Random crashes when dragging files

Lately, I’ve been getting frequent crashes of Mp3tag 3.31a on Windows 11 when dragging files into, out of, or even just across the application window. It’s not consistent, but it happens almost every day at least once.

The number and type of files doesn’t seem to matter. The files verify OK in foobar.

Often there’s an Alt+Tab involved, e.g. I’ll click on files and start dragging them, and while holding mouse button, I’ll use my other hand to press Alt+Tab(+more Tab keypresses as needed) to switch to the window I want to drop them into. Sometimes the crash happens without even releasing Alt; like as soon as Mp3tag is “visited” by this process, it crashes.

Dumps attached. The latter one (18004) was made with Mp3tag 3.31d.

CrashDumps.zip (773.6 KB)

Mp3tag.exe.18004.zip (237.8 KB)

Many thanks for reporting the issue and the crash dumps! I couldn't reproduce the issue myself, but identified a potential use-after-free of global memory inside OLE.

I've created an internal test version — it would be great if you could try reproducing the issue with this version (and send any crash reports, in case the problem persists)

https://download.mp3tag.de/support/874937CD-FE81-42C0-9D2A-694BB4B4CEC4-3-31-4-1/mp3tagv331d1-x64-setup.exe

The new build is much more stable. No crashes yet. I will keep you posted.

1 Like

CrashDumps.zip (1.3 MB)

Still getting some crashes. Dumps attached!

Well, that sucks. Thanks for the additional crash reports. At the moment, I see nothing in my code that relates to this, but I'll keep looking.

Does it happen only with Alt-tabbing to specific programs, do you need to perform a specific window-activation sequence, or does it appear to be totally random?

Also, I saw nothing outstanding in the module list, but do you have any system tools installed that might install system-wide hooks (e.g., DisplayFusion, WindowBlinds, ...)?

Please disregard the questions from my previous post for the moment. I've created a new internal test version, where I'm trying a workaround by deleting some of the drag data myself before COM gets a chance.

It would be great if you could try reproducing the issue with this version (and send any crash reports, in case the problem persists). Let's see...

https://download.mp3tag.de/support/874937CD-FE81-42C0-9D2A-694BB4B4CEC4-3-31-4-2/mp3tagv331d2-x64-setup.exe

Mp3tag.exe(1).103624.zip (244.6 KB)

This (crash log attached) was just when I selected some files and started to drag them from File Explorer, not even switching any windows at all.

Not sure about system-wide hooks. I am using TwinkleTray.

OK, thanks. Here is another internal test version. Please try reproducing the issue with this version (and send any crash reports, in case the problem persists).

https://download.mp3tag.de/support/874937CD-FE81-42C0-9D2A-694BB4B4CEC4-3-31-4-3/mp3tagv331d3-x64-setup.exe

Mp3tag.exe.75940.zip (247.8 KB)

Crash dump attached.

I'm out of ideas for the moment. It looks like someone else is freeing memory, which is later attempted to be deleted.

You can try using ShellExView to identify and disable any shell extensions that might interfere with drag and drop from Mp3tag (Microsoft = No and Type = Drag & Drop Handler).

I checked with ShellExView and ended up uninstalling a few things with drag & drop handlers: TeraCopy, WinRAR, Link Shell Extension, and PowerToys. Unfortunately, I still got the Mp3tag crashes. Yesterday I updated Windows, and I’m now experimenting with and without Twinkle Tray running. So far, it’s promising, but I want to test some more. I’ll update when I know more.

1 Like

Thanks so much for doing all these tests! Looking forwards and crossing fingers.

This is now fixed in Mp3tag v3.31e. Thanks again!

Just wanted to check in and see if the crashes are still occurring after you've updated your system and paused the handlers that might have been interfering?

Yes, still happening. I sent a PM last night to the other user who was having this problem to see if maybe we can figure out if there’s anything our systems have in common, but I’m losing hope.

I'm not giving up on this yet. I've re-implemented drag and drop using plain IDataObject and IDropSource.

Please try reproducing the issue with this version (and send any crash reports, in case the problem persists).

https://download.mp3tag.de/support/874937CD-FE81-42C0-9D2A-694BB4B4CEC4-3-31-6-1/mp3tagv331f1-x64-setup.exe

That seems to have done the trick. No crashes so far.

1 Like

That's just great! I've also included the change in the latest version Mp3tag v3.31h.

Thanks again for reporting, testing, and your patience throughout the whole process.

1 Like

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.