Suggestion: Filter [ ] regular expression


#1

Please could the Filter have a checkbox '[ ] regular expression' and it be off by default?

Quite a few times I have heard people to whom I have recommended Mp3tag complain often the filter is bugged, giving wrong results. I traced this to a character that Mp3tag interprets as a regexp character... with Mp3tag making no mention of this on the UI or in the Help AFAICT.

Thanks.


#2

My Vote +1

DD.20090901.1526.CEST


#3

Vote +1!

Also please give filter an optional delay e.g. apply filter 500ms after last keypress OR apply filter on Enter key press - to give you time to finish typing before the filtering starts.

When I have 150,000 tracks loaded I have to wait 10 seconds after every key press in filter while it filters on each combination of letters which I don't want.


#4

When I have 150,000 tracks loaded I have to wait 10 seconds after every key press in
filter while it filters on each combination of letters which I don't want.

I too find that crippling.

Also please give filter an optional delay e.g. apply filter 500ms after last keypress
OR apply filter on Enter key press - to give you time to finish typing before the filtering starts.

I would much prefer the proper solution - simply that refresh does not lock-out UI input e.g. runs on another thread.


#5

Just wanted to let you know that both are excellent ideas. I'm planning a major overhaul of the Filter for the next release.

Kind regards,
Florian


#6

I'm planning a major overhaul of the Filter for the next release.

Great! Sounds like good time for me to tell about the Mp3tag Filter of My Dreams :slight_smile:

  1. Larger Field drop-down list - wider, so I see all the field name, uncropped. Taller so I see more field names before scrolling.

  2. "Filter:" control accurately labelled e.g. "Value:".

  3. Unused space at right end of filter bar eliminated, making the Filter: control longer.

  4. A History drop-down arrow on the Filter: control.

  5. Filter's refresh of the track list keeps selected any selected tracks that are are in the new set (currently refresh unselects all.).

  6. A new column header right-click command "Filter" which enables filtering and sets Field to the column's field, read from the column's Customse Columns... "Value" property). If the Value spec is incompatible with the filter i.e. is not a single field placeholder, this command is disabled.

  7. A new tracklist property right-click command "Filter" which enables filtering, sets Filter "Field:" to the column's field (as above) and sets Filter "Filter:" to the track's property vallue. If "[X] regular expressions", the property value is escaped appropriately.

  8. Multiple filters!

EDIT:
:slight_smile:


Mein englisch ist ganz schlecht
#7

The current Development Build now comes with a completely rewritten filter supporting filter expressions, combined filters and a history. It now runs in a separate thread and updates the file list faster which should improve the overall experience.

Kind regards,
Florian


#8

This is absolutely brilliant. Thank you!


#9

The two things I would want most are a [ ] Regular expression checkbox and an 'Apply' button. Very good suggestions. I don't need, nor do I want, active filtering as I type.

I really can't figure out how to do anything at all with the current (2.44d) implementation.


#10

I don't need, nor do I want, active filtering as I type.

I think it would not unacceptable for Mp3tag to drop that feature, so of an Apply button was added, it should be conditional on a new '[ ] Apply filter automatically' checkbox, perhaps in options.


#11

Yes please make "filter as you type" optional. Its such a pain when you have a large file list.


#12

How many files is "large" for you? In my tests I used it with 100.000 generated files and found it to be fast and responsible.


#13

Sad to see the regexp checkbox didn't make it into the release. Glad to see the threaded processing did.