[WS] Discogs ALL

Sorry, but I think You misunderstood, this only could be possible if you want keep all your credits in %CREDITS%, not per track. Unfortunately WebSource does not offer any mathematical operations so this is quiet impossible.

1 & 2: No, mp3tag is not capable to do that.
3: No, but you can rename a file or move it elsewhere.

Btw, I'm not developer of mp3tag, just this websource.

Pufas,

Is the "Remove Fields Except" ACTION really necessary? I'm asking because it makes it impossible to run other scrips, like the Amazon & RYM, before it. Since your script is by far the best you really want to run it last to get artist, composer, and all the other tags that the other scripts also gets, right. I want to save tags from the others scripts like for example MOOD, THEME, ASIN and AMAZON REVIEW.

Wouldn't it be better if your ACTIONS only cleaned up your tag's?

//Windjammer

ps. I'll be asking more questions about your script, I love it!

I guess not, You can remove it if you like.

Pufas,

This one is a big one. There is so mush text in both the over all credits and the individual track credits so the script or mp3tag truncates a lot. Don't know where the problem lays, what do you think?

http://www.discogs.com/Shakira-Oral-Fixati...release/1473371

//Windjammer

Pufas,

The cleanup ACTIONS also delete any Album art. Guess this is not as designed, or?

Regards,

//Windjammer

It doesn't, it's just not displayed, but it's there. If you click on TMPCR or whatever in preview window you will see complete text.

Thanks I forgot to do that :slight_smile:

Btw, here's modded version of my script, if you plan to use that %CREDITS% tag, and add action at the end of discogs xml:

Replace
CREDITS
""
to
", "
(do not use ").

EDIT: v1.19 available.

Discogs_xml_all_edit.src (31.8 KB)

Hi Pufas,

Thanks, OK, sorry again for not digging deep enough in the wonders about this script... :rolleyes:

Anyway I noticed today that the script doesn't catch MUSIC BY. It does catch LYRICS BY and I'm guessing these values, MUSIC+LYRICS, will also go into AUTHOR...

//Windjammer

Thanks for this, but I'm not going to touch your code in this script... Might build an ACTION in the end that copies all individual fields to the CREDITS tag, per file, though...

//Windjammer

In the Shakira link above:
http://www.discogs.com/Shakira-Oral-Fixati...release/1473371

The script is never grabbing:
ACCORDION
BASS
CHOIR
CONCERTMASTER
DIRECTED BY
DRUMS
GUITAR
PERCUSSION
PHOTOGRAPHY
STRINGS
TRUMPET
Individual track PROGRAMMED BY

..and also the script doesn't grab:
Track 3 - Hips don't lie
Arranged By [Backing Vocals] - Olgi Chirino
- (It puts Olgi Chirino in VOCALS, should be in ARRANGED)
Co-producer, Programmed By - Jerry "Wonda" Duplessis*
- (not as PROGRAMMED)
Featuring [Backing Vocals], Co-producer, Guitar, Programmed By, Lyrics By, Music By - Wyclef Jean
- (not as FEATURING, PROGRAMMED)

Track 4 - Animal City
Percussion, Arranged By [Cumbia] - Shakira
- (guessing Shakira here as well as in the over all ARRANGED puts her twice in the tag. Seen this happen in other tags as well.)

Track 6 - Don't bother
Engineer [Recording] - Iker Gastaminsa , Jonathan Mover
- (Jonathan Mover isn't in ENGINEER)
Featuring [Backing Vocals], Co-producer, Keyboards, Music By - Gustavo Cerati
- (not in FEATURING, COPRODUCER, KEYBOARDS)
Lyrics By - Pedro Aznar
- (not in LYRICS)

Pfewww... Well, Pufas, I completely understand the impossibility of covering everything. The alternatives are just to many. For me the most important ones are LYRICS, MUSIC, FEATURING and VOCALS, the rest is a wonderful bonus and even if some things are missing it's bloody brilliant!!!

On a side note I think you should rename COPRODUCER to CO-PRODUCER.

Hope I don't push you over the edge with this, I'm so amazed by what you have done so far so I will use it never the less. Thank you!

//Windjammer

Posted v1.20, all fixed but, 3x Shakiras at track 4, I guess we need some supa-fancy reg exp.
maybe I'll think of something later, or bother dano again. ^_^ About CO-PRODUCER, i try to avoid tags with dashes or any other symbols but letters, I'll stick to COPRODUCER.

:w00t: :sorcerer: Amazing, please don't get a life! :wink: I'll dig into this the coming days! Believe me I have no problems with the COPRODUCER and I understand why you want to keep the tags clean from symbols from a programming p.o.v. Also I do know how to write an ACTION to call the tag what ever I want... :whistling:

Pufas, just thought I'd let you know I'm still here & I'm still digging your script. It's just gone beyond all expectations. Thanks again.

you may wanna try discogs tagger via foobar2000. it can fill a lot more than my script.

Last time I looked at Foobar's tagging abilities I couldn't find an option to not modify file dates. For some weird OCD-like reason I like my file dates untouched.

You have to download extra plugin or smth like that.

I have looked for such a thing more than once, but never found it. Foobar's plugins are strewn about all of creation so it's hard to find certain plugins sometimes.

Guess I'll keep looking.

Search for foo_discogs

I knew about foo_discogs, but I thought it modified the file date just like Foobar's tagger did. I'll take a closer look.

Oh now I get your question right. Yes it also changes the modification date.

There's a bug in last script, it creates empty keyboards tag. Here's patched version.

Discogs_xml_all.src (39.6 KB)